Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: downgrade transbank api version #266

Merged
merged 34 commits into from
Nov 21, 2023

Conversation

isabellaahc
Copy link
Contributor

  • downgrade API version to 1.2
  • remove deferred capture methods API 1.3

Webpay plus evidence:
image
image
image

Webpay plus deferred capture evidence:
image
image
image
image

Webpay plus mall evidence:
image
image

Webpay plus mall deferred capture evidence:
image
image
image

Webpay Oneclick evidence:
image
image
image

Webpay oneclick deferred capture evidence:
image
image
image
image

Webpay Full transaction evidence:
image
image

Webpay full transaction deferred capture evidence:
image
image

mvarlic
mvarlic previously approved these changes Nov 20, 2023
Copy link
Contributor

@mvarlic mvarlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@mvarlic mvarlic self-requested a review November 20, 2023 19:33
Copy link
Contributor

@mvarlic mvarlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Matiasnickolas Matiasnickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 💪

Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isabellaahc isabellaahc merged commit 1817694 into master Nov 21, 2023
9 checks passed
@isabellaahc isabellaahc deleted the feat/downgrade-tbk-api-version branch November 21, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants